disagg: Add O11y on object store usage summary of each tiflash store (#10764)#10768
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@JaySon-Huang This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: JaySon-Huang <tshent@qq.com>
|
/unhold |
[LGTM Timeline notifier]Timeline:
|
|
@kolafish: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin, kolafish, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c1faf95
into
pingcap:release-nextgen-20251011
This is an automated cherry-pick of #10764
What problem does this PR solve?
Issue Number: ref #10763
Problem Summary:
What is changed and how it works?
Add periodic S3 storage summary in
S3GCManagerService:summary_interval_seconds.summary_interval_seconds <= 0, the periodic task is not registered.http://${TIFLASH_IP}:${TIFLASH_STATUS_PORT}/tiflash/remote/infohttps://github.com/pingcap/tiflash/blob/master/docs/tiflash_http_api.md#fetch-the-remote-storage-summary-from-tiflash-write-nodeAdd graceful shutdown behavior during summary scan:
getStoreStorageSummarychecksshutdown_calledinlistPrefixloop and exits early.Add per-store summary metrics:
tiflash_storage_s3_store_summary_bytes{store_id, type}typein{data_file_bytes, dt_file_bytes}getStoreStorageSummarycompletion.Wire configuration from settings to S3GC config:
profiles.default.remote_summary_interval_seconds(default 0, disabled)TMTContextand passed intoS3GCManagerService.Check List
Tests
Side effects
Documentation
Release note
Summary by CodeRabbit
New Features
Documentation